Don't write encryption keyfiles to an unencrypted root partition#4349
Merged
svartkanin merged 1 commit intoarchlinux:masterfrom Apr 1, 2026
Merged
Conversation
Contributor
Author
|
This might be as straightforward as it seems, needs tested still, so in draft. I suspect we will run into an issue because we still need a crypttab entry but with none as the keyfile so systemd prompts for the passphrase. Edit: This is the case, I updated the PR to address ^^ |
dylanmtaylor
force-pushed
the
fix-keyfile-unencrypted-root
branch
from
7bc3274 to
a7e00dc
Compare
dylanmtaylor
force-pushed
the
fix-keyfile-unencrypted-root
branch
from
a7e00dc to
56566fa
Compare
Contributor
Author
|
Testing: Manual partitioning: |
Contributor
Author
|
This is tested and confirmed to work correctly. ^^ After entering the /home password, I was able to log into the system normally. |
svartkanin
approved these changes
Apr 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1856
When encrypting partitions like /home but not /, the keyfiles were written to the unencrypted root filesystem in plaintext, defeating the purpose of the encryption.
Now keyfiles are only generated when root is also encrypted. Otherwise, systemd-cryptsetup will prompt for the passphrase at boot instead.